refactor: apply `webpack-defaults` #81

TrySound · 2017-07-05T07:14:20Z

I disabled some rules locally and disabled linebreak-style because it sucks for windows users and auto conversion happen in git out of the box.

Issues

Fixes webpack-defaults upgrade #57
Fixes refactor: apply webpack-defaults #81

TrySound · 2017-07-05T07:22:05Z

Any ideas why they are failed?

TrySound · 2017-07-05T10:38:32Z

Why webpack canary is default?

joshwiens · 2017-07-05T10:41:29Z

Latest is default

joshwiens · 2017-07-05T10:41:44Z

Canary run once in Travis on Node8. If the question is why is it targeting latest that's because it's a pipe dream to think anyone, to include me is going to keep the travis test Webpack version current across all of our libs.

michael-ciniawsky

Check the various config files for correctness, webpack-defaults sometimes leaves old bits in place on the first run, otherwise 👍 . I do the README upgrade during the day 😛

michael-ciniawsky · 2017-07-05T13:03:46Z

.eslintrc

@@ -0,0 +1,20 @@
+{
+  "extends": "webpack",
+  "rules": {


I this added intentionally or was this the previous config ? webpack-defaults doesn't always remove all previous settings, when applied for the first time, you need to double check here :)

⚠️ This can also happen in the .bablerc file

michael-ciniawsky · 2017-07-05T13:07:08Z

src/index.js

+      outputOptions[name] = this.options.worker.output[name];
+    });
+  }
+  /* eslint-disable no-underscore-dangle */


If it is an entire rule move it to the top :)

Not entire. Just for this case with child compiler.

michael-ciniawsky · 2017-07-05T13:08:58Z

test/test.js

@@ -0,0 +1,221 @@
+/* eslint-disable linebreak-style */
+
+import assert from 'assert';


Better to use the buildin Jest Assertions expect instead ?

Yes, Jest internals + snapshots only.

michael-ciniawsky · 2017-07-05T13:15:43Z

You merged a few PR's, but some don't conform to the Angular Commit Convention, standard-version (webpack-defaults) requires this convention for CHANGELOG autogeneration. Please rebase the history, I normally at least check if the PR commit message conforms if I'm not that useful otherwise 😛 , but you were faster :D I will mark the conflicting commits here

michael-ciniawsky · 2017-07-05T13:30:12Z

2d7e1a0 => chore(release): 0.8.1
#80 => test: improve named workers via `options`
#79 => docs(README): add typescript example
#78 => feat: add `options` validation (`schema-utils`)
#66 => docs(README): add worker message example

michael-ciniawsky · 2017-07-05T13:52:59Z

package.json

-      "strict": 0
-    }
+    "test": "jest",
+    "posttest": "eslint .",


Seems to be a leftover aswell ? 🙃

michael-ciniawsky · 2017-07-05T13:54:54Z

src/index.js

+      }
+      compilation.cache = compilation.cache[subCache];
+    }
+    /* eslint-enable no-param-reassign */


This rule should be relaxed in eslint-config-webpack, I see this line it in every webpack-defaults PR :D

We do a ton of it but really shouldn't but none the less, we do need to update the config to back off on it a bit.

joshwiens · 2017-07-05T15:20:53Z

package.json

  "peerDependencies": {
-    "webpack": ">=0.9 <2 || ^2.1.0-beta || ^2.2.0"
+    "webpack": "^2.0.0 || >= 3.0.0-rc.0 || ^3.0.0"
  },


Remove the 3.0.0-rc.0. We don't support beta & RC builds once the major in question hits @latest

Then why defaults added it?

Fair point, one sec.

It's already fixed in master. Pick up webpack-defaults@1.5.0

joshwiens · 2017-07-05T15:21:16Z

package.json

    "eslint-plugin-import": "^2.2.0",
+    "jest": "^20.0.4",
+    "lint-staged": "^4.0.0",
    "mocha": "^3.2.0",


Remove mocha

TrySound · 2017-07-05T21:18:16Z

.gitignore

+.idea
+.vscode
+*.sublime-project
+*.sublime-workspace


Really? Is this stuff necessary? Should be always developer responsibility, not project.

TrySound · 2017-07-05T21:26:01Z

.eslintrc

@@ -0,0 +1,20 @@
+{


@d3viant0ne Do you know .eslintrc without extension is deprecated?
http://eslint.org/docs/user-guide/configuring#configuration-file-formats

Yes, it's on the list to be changed when we switch everything over to just use Prettier in defaults 2.0

renchap · 2017-07-17T08:58:01Z

Any news on this PR? This is blocking our update to Webpack 3.

mikegreiling · 2017-07-24T17:46:12Z

Is there anything we can do to help this PR along? We're unable to upgrade to webpack v3 until this is merged 🙁

dbslone · 2017-08-01T17:49:35Z

@TrySound @d3viant0ne - Any updates with this PR? I can pick up where the PR left off to get the tests passing on Travis but wanted to check in first so i don't duplicate anything that has already been done.

TrySound · 2017-08-01T18:41:28Z

@dbslone No updates yet. You may finish it.

dbslone · 2017-08-08T05:05:20Z

The tests are passing locally for me. At first I thought it was because I was on node 8 but after installing node 6.11 the tests are still passing.

Is anything else left for this PR to be approved?

joshwiens · 2017-08-08T06:33:51Z

@dbslone - I'm going to get a patch out with #85 first & wrap this up after the fact.

michael-ciniawsky · 2017-10-12T16:28:13Z

Got it stats.toJson('minimal') => stats.toJson() 🎉 😛

codecov · 2017-10-12T16:32:47Z

Codecov Report

❗ No coverage uploaded for pull request base (master@2051a3a). Click here to learn what that means.
The diff coverage is 77.41%.

@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage          ?   64.86%           
=========================================
  Files             ?        5           
  Lines             ?       74           
  Branches          ?       26           
=========================================
  Hits              ?       48           
  Misses            ?       23           
  Partials          ?        3

Impacted Files	Coverage Δ
src/workers/InlineWorker.js	`0% <0%> (ø)`
src/cjs.js	`0% <0%> (ø)`
src/workers/index.js	`100% <100%> (ø)`
src/Error.js	`100% <100%> (ø)`
src/index.js	`86.11% <86.11%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2051a3a...a6d8208. Read the comment docs.

- Currently a change that is in defaults master

* Add webpack-defaults * ci(Appveyor): Run on latest - Currently a change that is in defaults master * chore(defaults): v1.4.0...1.6.0 * fix(cjs): export pitching loader * test: stats.toJson('minimal') => stats.toJson() * style: improve code style

TrySound requested review from joshwiens and michael-ciniawsky July 5, 2017 07:14

michael-ciniawsky suggested changes Jul 5, 2017

View reviewed changes

michael-ciniawsky changed the title ~~Add webpack-defaults~~ refactor: apply webpack-defaults Jul 5, 2017

michael-ciniawsky added this to the 1.0.0 milestone Jul 5, 2017

michael-ciniawsky added priority: 3 (required) pr_action: Review semver: Major status: Pending type: Refactor labels Jul 5, 2017

michael-ciniawsky reviewed Jul 5, 2017

View reviewed changes

joshwiens suggested changes Jul 5, 2017

View reviewed changes

TrySound mentioned this pull request Jul 5, 2017

Add webpack 3.0 to peerDependencies #83

Closed

TrySound commented Jul 5, 2017

View reviewed changes

renchap mentioned this pull request Jul 13, 2017

Webpack 3.0 support #75

Closed

danez mentioned this pull request Aug 3, 2017

chore: Allow Webpack v3.x as a peerDependency #85

Merged

joshwiens self-assigned this Aug 12, 2017

michael-ciniawsky requested review from alexander-akait, joshwiens and michael-ciniawsky October 12, 2017 16:29

michael-ciniawsky approved these changes Oct 12, 2017

View reviewed changes

michael-ciniawsky force-pushed the webpack-defaults branch from 853aa74 to 81f7aa1 Compare October 13, 2017 09:25

joshwiens approved these changes Oct 14, 2017

View reviewed changes

This was referenced Oct 14, 2017

feat: add support for SharedWorker (options.mode) #98

Closed

feat: add support for ServiceWorker (options.mode) #99

Closed

michael-ciniawsky force-pushed the webpack-defaults branch from 81f7aa1 to bf3b723 Compare October 14, 2017 11:41

TrySound and others added 5 commits October 19, 2017 07:57

Add webpack-defaults

fa7abeb

ci(Appveyor): Run on latest

cd2e4d2

- Currently a change that is in defaults master

chore(defaults): v1.4.0...1.6.0

cf687ad

fix(cjs): export pitching loader

35290a9

test: stats.toJson('minimal') => stats.toJson()

2283106

michael-ciniawsky force-pushed the webpack-defaults branch 3 times, most recently from e21a940 to 8c5dd95 Compare October 19, 2017 13:14

style: improve code style

a6d8208

michael-ciniawsky force-pushed the webpack-defaults branch from 8c5dd95 to a6d8208 Compare October 19, 2017 13:19

joshwiens merged commit 09705fb into master Oct 21, 2017

Swizec mentioned this pull request Oct 24, 2017

Weird install issues with latest 3 commits on master #104

Closed

michael-ciniawsky removed this from the 2.0.0 milestone Oct 24, 2017

michael-ciniawsky deleted the webpack-defaults branch February 25, 2018 06:37

michael-ciniawsky added status: Approved and removed pr_action: Review priority: 3 (required) status: Pending labels Feb 25, 2018

		@@ -0,0 +1,221 @@
		/* eslint-disable linebreak-style */

		import assert from 'assert';

Uh oh!

Uh oh!

refactor: apply webpack-defaults #81

refactor: apply webpack-defaults #81

Uh oh!

Conversation

TrySound commented Jul 5, 2017 • edited by michael-ciniawsky Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Uh oh!

TrySound commented Jul 5, 2017

Uh oh!

TrySound commented Jul 5, 2017

Uh oh!

joshwiens commented Jul 5, 2017

Uh oh!

joshwiens commented Jul 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michael-ciniawsky left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky commented Jul 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michael-ciniawsky commented Jul 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michael-ciniawsky Jul 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky Jul 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joshwiens Jul 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

renchap commented Jul 17, 2017

Uh oh!

mikegreiling commented Jul 24, 2017

Uh oh!

dbslone commented Aug 1, 2017

Uh oh!

TrySound commented Aug 1, 2017

Uh oh!

dbslone commented Aug 8, 2017

Uh oh!

joshwiens commented Aug 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michael-ciniawsky commented Oct 12, 2017

Uh oh!

codecov bot commented Oct 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

refactor: apply `webpack-defaults` #81

refactor: apply `webpack-defaults` #81

TrySound commented Jul 5, 2017 •

edited by michael-ciniawsky

Loading

joshwiens commented Jul 5, 2017 •

edited

Loading

michael-ciniawsky commented Jul 5, 2017 •

edited

Loading

michael-ciniawsky commented Jul 5, 2017 •

edited

Loading

michael-ciniawsky Jul 5, 2017 •

edited

Loading

michael-ciniawsky Jul 5, 2017 •

edited

Loading

joshwiens Jul 6, 2017 •

edited

Loading

joshwiens commented Aug 8, 2017 •

edited

Loading

codecov bot commented Oct 12, 2017 •

edited

Loading